I checked changes for this into cvs.

Suggestion looks good;  Thanks Mike.

--- "Spencer Shepler \"NFSv4.1 Issue Tracker\""
<issue-tracker@nfsv4-editor.org> wrote:

> 
> New submission from Spencer Shepler <spencer.shepler@gmail.com>:
> 
> There are responses that contain opaque device_addrs
> that are returned to the client without inband context
> of what layout type the device_addr represents.  This
> technically isn't a problem since the client knows
> the context from the original call.  However, to ease
> protocol "validation" by the client and the building
> of network trace tools like snoop and ethereal, it is
> best to include the laytouttype along with the
> device_addr.  This is a straightforward change and 
> the new structures would look something like this:
> 
> struct devlist_item4 {
> 	deviceid4		dli_id;
> 	layouttype4		dli_layout_type;	
> 	opaque			dli_device_addr<>;
> };

I prefer:

struct stordevice_addr {
  layouttype4		sda_layout_type;
  opaque                sda_addr_body; 
};

 struct devlist_item4 {
 	deviceid4		dli_id;
 	stordevice_addr         dli_addr;
 };

> 
> struct GETDEVICEINFO4resok {
> 	layouttype4		gdir_layout_type;	
> 	opaque			gdir_device_addr<>;
> };

struct GETDEVICEINFO4resok {
 	struct stordevice_addr  gdir_device_addr;	
};

> struct devlist_item4 {
> 	deviceid4		dli_id;
> 	layouttype4		dli_layout_type;	
> 	opaque			dli_device_addr<>;
> };

I prefer:

struct stordevice_addr {
  layouttype4		sda_layout_type;
  opaque                sda_addr_body; 
};

 struct devlist_item4 {
 	deviceid4		dli_id;
 	stordevice_addr         dli_addr;
 };

> 
> struct GETDEVICEINFO4resok {
> 	layouttype4		gdir_layout_type;	
> 	opaque			gdir_device_addr<>;
> };

struct GETDEVICEINFO4resok {
 	struct stordevice_addr  gdir_device_addr;	
};

There are responses that contain opaque device_addrs
that are returned to the client without inband context
of what layout type the device_addr represents.  This
technically isn't a problem since the client knows
the context from the original call.  However, to ease
protocol "validation" by the client and the building
of network trace tools like snoop and ethereal, it is
best to include the laytouttype along with the
device_addr.  This is a straightforward change and 
the new structures would look something like this:

struct devlist_item4 {
	deviceid4		dli_id;
	layouttype4		dli_layout_type;	
	opaque			dli_device_addr<>;
};

struct GETDEVICEINFO4resok {
	layouttype4		gdir_layout_type;	
	opaque			gdir_device_addr<>;
};